[relay-runtime] Move PreloadableConcreteRequest from react-relay to relay-runtime

[tobias-tengler]

I'm working on adding @preloadable support to the OSS version of Relay: facebook/relay#4515
The generated $parameters.ts file needs to import the PreloadableConcreteRequest type. Currently this type is defined in @types/react-relay for seemingly no reason. The other request types are defined in @types/relay-runtime.
This PR moves PreloadableConcreteRequest to @types/relay-runtime so the relay-compiler doesn't have to suddenly start importing types from react-relay.

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run pnpm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: @preloadable support facebook/relay#4110 (comment)

[typescript-bot]

@tobias-tengler Thank you for submitting this PR!

This is a live comment which I will keep updated.

2 packages in this PR

• react-relay — on npm, on unpkg
• relay-runtime — on npm, on unpkg

Code Reviews

Because this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

• ❌ No merge conflicts
• ✅ Continuous integration tests have passed
• 🕐 A DT maintainer needs to approve changes which affect more than one package

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 31 days — it is considered abandoned, and therefore closed!

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 67321,
  "author": "tobias-tengler",
  "headCommitOid": "2be50889e44faa2dbcf7547fab562442711b6cc5",
  "mergeBaseOid": "39544fd1c88147d33653d7d414c4e4b746a8a955",
  "lastPushDate": "2023-11-05T19:46:46.000Z",
  "lastActivityDate": "2023-11-17T01:10:05.000Z",
  "hasMergeConflict": true,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "react-relay",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-relay/hooks.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-relay/relay-hooks/EntryPointTypes.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-relay/relay-hooks/loadQuery.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-relay/relay-hooks/useQueryLoader.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-relay/v7/lib/relay-experimental/EntryPointTypes.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-relay/v7/lib/relay-experimental/loadQuery.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-relay/v7/lib/relay-experimental/useQueryLoader.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "alloy",
        "maraisr",
        "edvinerikson",
        "levibuzolic"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "relay-runtime",
      "kind": "edit",
      "files": [
        {
          "path": "types/relay-runtime/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/relay-runtime/lib/util/RelayConcreteNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/relay-runtime/relay-runtime-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "alloy",
        "maraisr",
        "morrys",
        "levibuzolic"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "stale",
      "reviewer": "maraisr",
      "date": "2023-11-06T08:22:05.000Z",
      "abbrOid": "28d0f0c"
    }
  ],
  "mainBotCommentID": 1793829726,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @alloy @maraisr @edvinerikson @levibuzolic @morrys — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

@tobias-tengler Thank you for submitting this PR!

This is a live comment which I will keep updated.

2 packages in this PR

• react-relay — on npm, on unpkg
• relay-runtime — on npm, on unpkg

Code Reviews

Because this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

• ❌ No merge conflicts
• ✅ Continuous integration tests have passed
• 🕐 A DT maintainer needs to approve changes which affect more than one package

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 31 days — it is considered abandoned, and therefore closed!

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 67321,
  "author": "tobias-tengler",
  "headCommitOid": "2be50889e44faa2dbcf7547fab562442711b6cc5",
  "mergeBaseOid": "39544fd1c88147d33653d7d414c4e4b746a8a955",
  "lastPushDate": "2023-11-05T19:46:46.000Z",
  "lastActivityDate": "2023-11-17T01:10:05.000Z",
  "hasMergeConflict": true,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "react-relay",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-relay/hooks.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-relay/relay-hooks/EntryPointTypes.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-relay/relay-hooks/loadQuery.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-relay/relay-hooks/useQueryLoader.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-relay/v7/lib/relay-experimental/EntryPointTypes.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-relay/v7/lib/relay-experimental/loadQuery.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-relay/v7/lib/relay-experimental/useQueryLoader.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "alloy",
        "maraisr",
        "edvinerikson",
        "levibuzolic"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "relay-runtime",
      "kind": "edit",
      "files": [
        {
          "path": "types/relay-runtime/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/relay-runtime/lib/util/RelayConcreteNode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/relay-runtime/relay-runtime-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "alloy",
        "maraisr",
        "morrys",
        "levibuzolic"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "stale",
      "reviewer": "maraisr",
      "date": "2023-11-06T08:22:05.000Z",
      "abbrOid": "28d0f0c"
    }
  ],
  "mainBotCommentID": 1793829726,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @alloy @maraisr @edvinerikson @levibuzolic @morrys — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

@tobias-tengler The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[typescript-bot]

@tobias-tengler The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[typescript-bot]

@tobias-tengler The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[maraisr]

Nice work mate, thank you so much! Left one comment

[typescript-bot]

@maraisr Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[maraisr]

Looks good to me ✨ thank you so much

[typescript-bot]

@tobias-tengler Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

[typescript-bot]

@maraisr Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[typescript-bot]

Re-ping @alloy, @maraisr, @edvinerikson, @levibuzolic, @morrys:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

[maraisr]

Think we might wait for this to land on the upstream, before merging this.

[typescript-bot]

@tobias-tengler Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

[typescript-bot]

@tobias-tengler I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Dec 17th (in a week) if the issues aren't addressed.

[typescript-bot]

@tobias-tengler To keep things tidy, we have to close PRs that aren't mergeable and don't have activity in the last month. No worries, though — please open a new PR if you'd like to continue with this change. Thank you!