[@types/splunk-logging] Remove extraneous dependency of request

[exadeci]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run pnpm test <package to test>.
• Provide a URL to documentation or source code which provides context for the suggested changes: <>
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

The request dependency has long been removed from splunk-logging but it's still marked as a dependency in @types which is causing warnings with dependabot.

[typescript-bot]

@exadeci Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

2 packages in this PR

• splunk-bunyan-logger — on npm, on unpkg
• splunk-logging — on npm, on unpkg

Code Reviews

This PR can be merged once it's reviewed.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Type definition owners or DT maintainers needs to approve changes which affect more than one package

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 69028,
  "author": "exadeci",
  "headCommitOid": "ccee1289ecc7dd70b38bdece9755597c259144a2",
  "mergeBaseOid": "1db422a28db16fb8c3fe766b8d3e72fad2051992",
  "lastPushDate": "2024-03-18T02:54:47.000Z",
  "lastActivityDate": "2024-04-08T01:32:10.000Z",
  "maintainerBlessed": "Waiting for Code Reviews",
  "mergeOfferDate": "2024-04-05T18:04:15.000Z",
  "mergeRequestDate": "2024-04-08T01:32:10.000Z",
  "mergeRequestUser": "exadeci",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "splunk-bunyan-logger",
      "kind": "edit",
      "files": [
        {
          "path": "types/splunk-bunyan-logger/splunk-bunyan-logger-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "bricka"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "splunk-logging",
      "kind": "edit",
      "files": [
        {
          "path": "types/splunk-logging/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/splunk-logging/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/splunk-logging/splunk-logging-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "bricka",
        "BoruiGu"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "RyanCavanaugh",
      "date": "2024-04-05T18:03:35.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 2002784084,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @bricka @BoruiGu — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

@exadeci The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[typescript-bot]

@exadeci The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[typescript-bot]

Re-ping @bricka, @BoruiGu:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

[typescript-bot]

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @exadeci.

(Ping @bricka, @BoruiGu.)

[exadeci]

Ready to merge

[showi]

This break the way the documentation say to use requestOptions!

https://www.npmjs.com/package/splunk-logging

var SplunkLogger = require("splunk-logging").Logger;

var config = {
    token: "your-token-here",
    url: "https://splunk.local:8088"
};

var Logger = new SplunkLogger(config);

// Enable SSL certificate validation
Logger.requestOptions.strictSSL = true;

[Mikescops]

Hello here, @exadeci @RyanCavanaugh
I don't know why this was approved and merged, the code of the splunk-logger still uses requestOptions.

https://github.com/splunk/splunk-javascript-logging/blob/cf039fbcc601bf8365b4f34397df85339ca112b4/splunklogger.js#L416

Let's revert this please.

[Mikescops]

Opened a ticket for it: #69360