Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@types/splunk-logging] Revert "Remove extraneous dependency of request" #69367

Merged

Conversation

ghost
Copy link

@ghost ghost commented Apr 16, 2024

Reverts #69028

@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 16, 2024

@codershiba Thank you for submitting this PR!

This is a live comment which I will keep updated.

2 packages in this PR

Code Reviews

Because this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ A DT maintainer needs to approve changes which affect more than one package

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69367,
  "author": "codershiba",
  "headCommitOid": "cc3d5df6f7c186b3390f265fceb8c09939aae1a9",
  "mergeBaseOid": "8b65be739e235dedcc9c557783ac2cf9d632c739",
  "lastPushDate": "2024-04-16T08:56:47.000Z",
  "lastActivityDate": "2024-04-18T18:29:25.000Z",
  "mergeOfferDate": "2024-04-18T17:27:37.000Z",
  "mergeRequestDate": "2024-04-18T18:29:25.000Z",
  "mergeRequestUser": "codershiba",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "splunk-bunyan-logger",
      "kind": "edit",
      "files": [
        {
          "path": "types/splunk-bunyan-logger/splunk-bunyan-logger-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "bricka"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "splunk-logging",
      "kind": "edit",
      "files": [
        {
          "path": "types/splunk-logging/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/splunk-logging/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/splunk-logging/splunk-logging-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "bricka",
        "BoruiGu"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "andrewbranch",
      "date": "2024-04-18T17:26:58.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 2058586529,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @bricka @BoruiGu — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Apr 16, 2024
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Apr 18, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in New Pull Request Status Board Apr 18, 2024
@typescript-bot
Copy link
Contributor

@codershiba: Everything looks good here. I am ready to merge this PR (at cc3d5df) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@ghost
Copy link
Author

ghost commented Apr 18, 2024

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Apr 18, 2024
@typescript-bot typescript-bot merged commit 9ff6856 into DefinitelyTyped:master Apr 18, 2024
4 checks passed
@ghost ghost deleted the revert-69028-master branch April 18, 2024 18:30
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Edits multiple packages Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants