-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@types/splunk-logging] Revert "Remove extraneous dependency of request" #69367
[@types/splunk-logging] Revert "Remove extraneous dependency of request" #69367
Conversation
…ependenc…" This reverts commit a6ba14d.
@codershiba Thank you for submitting this PR! This is a live comment which I will keep updated. 2 packages in this PRCode ReviewsBecause this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69367,
"author": "codershiba",
"headCommitOid": "cc3d5df6f7c186b3390f265fceb8c09939aae1a9",
"mergeBaseOid": "8b65be739e235dedcc9c557783ac2cf9d632c739",
"lastPushDate": "2024-04-16T08:56:47.000Z",
"lastActivityDate": "2024-04-18T18:29:25.000Z",
"mergeOfferDate": "2024-04-18T17:27:37.000Z",
"mergeRequestDate": "2024-04-18T18:29:25.000Z",
"mergeRequestUser": "codershiba",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "splunk-bunyan-logger",
"kind": "edit",
"files": [
{
"path": "types/splunk-bunyan-logger/splunk-bunyan-logger-tests.ts",
"kind": "test"
}
],
"owners": [
"bricka"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "splunk-logging",
"kind": "edit",
"files": [
{
"path": "types/splunk-logging/index.d.ts",
"kind": "definition"
},
{
"path": "types/splunk-logging/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/splunk-logging/splunk-logging-tests.ts",
"kind": "test"
}
],
"owners": [
"bricka",
"BoruiGu"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "andrewbranch",
"date": "2024-04-18T17:26:58.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2058586529,
"ciResult": "pass"
} |
🔔 @bricka @BoruiGu — please review this PR in the next few days. Be sure to explicitly select |
@codershiba: Everything looks good here. I am ready to merge this PR (at cc3d5df) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
Ready to merge |
Reverts #69028