Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serve-static] restore old http import #69258

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

jakebailey
Copy link
Member

@typescript-bot
Copy link
Contributor

@jakebailey Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • 🕐 Continuous integration tests are still running
  • 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69258,
  "author": "jakebailey",
  "headCommitOid": "356f91194688571462bb54128c77f8aabc4cd215",
  "mergeBaseOid": "03cf070c1f9f9937acad8bcb90eb0011f004a248",
  "lastPushDate": "2024-04-03T05:29:38.000Z",
  "lastActivityDate": "2024-04-03T05:29:38.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "serve-static",
      "kind": "edit",
      "files": [
        {
          "path": "types/serve-static/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "urossmolnik",
        "LinusU",
        "devanshj"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "ciResult": "unknown"
}

@typescript-bot typescript-bot added Critical package Untested Change This PR does not touch tests labels Apr 3, 2024
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Apr 3, 2024
@typescript-bot
Copy link
Contributor

🔔 @urossmolnik @LinusU @devanshj — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@DangerBotOSS
Copy link

Formatting

The following files are not formatted:

  1. types/serve-static/index.d.ts

Consider running pnpm dprint fmt on these files to make review easier.

Generated by 🚫 dangerJS against 356f911

@jakebailey jakebailey merged commit adcc05a into master Apr 3, 2024
8 checks passed
@jakebailey jakebailey deleted the jakebailey-patch-1 branch April 3, 2024 05:38
@typescript-bot typescript-bot removed this from Waiting for Code Reviews in New Pull Request Status Board Apr 3, 2024
@stu43005
Copy link

stu43005 commented Apr 3, 2024

Thank you for the quick fix🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants