[@types/serve-static] Remove dependency on @types/mime

[ghost]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run pnpm test serve-static.

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: <>
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

[typescript-bot]

@codershiba Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• serve-static — on npm, on unpkg

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 69231,
  "author": "codershiba",
  "headCommitOid": "9df89f8a703e49ffc7f88d56d04140aff52372fd",
  "mergeBaseOid": "41aa59f8e323a93b98ecea69fcf67a7a0a2cfa67",
  "lastPushDate": "2024-04-01T06:12:31.000Z",
  "lastActivityDate": "2024-04-02T16:29:49.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "serve-static",
      "kind": "edit",
      "files": [
        {
          "path": "types/serve-static/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/serve-static/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "urossmolnik",
        "LinusU",
        "devanshj"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2024-04-02T16:29:49.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 2029322084,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @urossmolnik @LinusU @devanshj — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

@codershiba Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• serve-static — on npm, on unpkg

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 69231,
  "author": "codershiba",
  "headCommitOid": "9df89f8a703e49ffc7f88d56d04140aff52372fd",
  "mergeBaseOid": "41aa59f8e323a93b98ecea69fcf67a7a0a2cfa67",
  "lastPushDate": "2024-04-01T06:12:31.000Z",
  "lastActivityDate": "2024-04-02T16:29:49.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "serve-static",
      "kind": "edit",
      "files": [
        {
          "path": "types/serve-static/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/serve-static/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "urossmolnik",
        "LinusU",
        "devanshj"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2024-04-02T16:29:49.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 2029322084,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @urossmolnik @LinusU @devanshj — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[jakebailey]

Why?

[esetnik]

I think the correct fix is in a219ae4 since mime v4 ships with it's own types that may end up being incompatible with @types/serve-static.

[stu43005]

I think the most accurate solution would be to change the dependency to @types/send.

Because serve-static actually depends on send package instead of mime.

see: https://github.com/expressjs/serve-static/blob/9b5a12a76f4d70530d2d2a8c7742e9158ed3c0a4/index.js#L29

Edit:
And @types/send has the correct dependency on @types/mime@^1 !

[DangerBotOSS]

Formatting

The following files are not formatted:

1. types/serve-static/index.d.ts

Consider running pnpm dprint fmt on these files to make review easier.

Generated by 🚫 dangerJS against 9df89f8

[AviVahl]

Why?

When #69213 landed, half the web broke. That's why. :)
@types/express use @types/serve-static. @types/serve-static used "@types/mime": "*", which broke once @types/mime@4 released.

Like @stu43005 wrote, serve-static actually uses send, which uses an older mime package version (and its relevant types).

refs:
firebase/firebase-admin-node#2512
googleapis/nodejs-storage#2434
fastify/send#60

[jakebailey]

Then we should revert #69213 then simply delete it without a shim. @types/mime was far too large to publish a shim for.

[jakebailey]

No, nevermind, the shim package is fine as it only applied to mime v4. But we should fix this package.

[jakebailey]

I'm not sure why moving it to send helps, though; that package is still using @types/mime@*.

[AviVahl]

TBH, it looks like the change here is the correct way to go.
mime@4 does have built-in types, so it should probably follow the usual procedure of deprecating a @types packages.

It's just that packages that depended on it using "*" need to get fixed.

[AviVahl]

I'm not sure why moving it to send helps, though; that package is still using @types/mime@*.

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/send/package.json
"@types/mime": "^1",

[jakebailey]

I apparently can't read!

[AviVahl]

Thank you for merging.
master is green, but no new @types/serve-static release yet...?
https://www.npmjs.com/package/@types/serve-static

[ghost]

Thank you for merging. master is green, but no new @types/serve-static release yet...? https://www.npmjs.com/package/@types/serve-static

Takes some time I guess

[jakebailey]

Publishing happens every half hour; give it like 5 minutes or so.

[ghost]

Sorry for breaking this and causing so much chaos but I guess this was the only major package here that depending on @types/mime: "*"

[jakebailey]

All good, our tooling unfortunately can't detect this kind of break because at the point at which a package is removed, the dummy package has not yet been published to npm. A known downside of the new pnpm layout that we need to figure out, probably by erroring on * deps which are present in notNeededPackages.

[stu43005]

Just a note

This PR changes the import to node:http, which only supports @types/node@>=14.18.0.

[jakebailey]

Feel free to send a PR and tag me, that seemed like an unnecessary change I missed.

[jakebailey]

Actually, just sent #69258