Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ovenplayer playback event listener callback #69652

Conversation

Emzawadzki
Copy link
Contributor

@Emzawadzki Emzawadzki commented May 21, 2024

Please fill in this template.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <<url here>>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

@typescript-bot
Copy link
Contributor

typescript-bot commented May 21, 2024

@Emzawadzki Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Inactive

This PR has been inactive for 10 days — please merge or say something if there's a problem, otherwise it will be closed!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69652,
  "author": "Emzawadzki",
  "headCommitOid": "e3986f3df5063485088ef29e2d754ad4545a25bf",
  "mergeBaseOid": "1ce6391919316cded9edf4aeaadddabc2d17eda4",
  "lastPushDate": "2024-05-21T11:36:45.000Z",
  "lastActivityDate": "2024-06-10T06:00:20.000Z",
  "mergeOfferDate": "2024-05-30T08:25:17.000Z",
  "mergeRequestDate": "2024-06-10T06:00:20.000Z",
  "mergeRequestUser": "SangwonOh",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "ovenplayer",
      "kind": "edit",
      "files": [
        {
          "path": "types/ovenplayer/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ovenplayer/ovenplayer-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "SangwonOh",
        "dygy"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "Anonymous4078",
      "date": "2024-05-30T08:24:41.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2122435375,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @SangwonOh @dygy — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@Emzawadzki
Copy link
Contributor Author

Emzawadzki commented May 21, 2024

Tests fail (also before changes made) due to export default, I'm not sure what's the best way to sort it out. Would appreciate some guidance on how to fix it.

@typescript-bot typescript-bot added Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner labels May 30, 2024
@typescript-bot
Copy link
Contributor

@Emzawadzki: Everything looks good here. I am ready to merge this PR (at e3986f3) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@SangwonOh, @dygy: you can do this too.)

@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Jun 9, 2024
@typescript-bot
Copy link
Contributor

Re-ping @Emzawadzki / @SangwonOh, @dygy:

This PR has been ready to merge for over a week, and I haven't seen any requests to merge it. I will close it on Jun 29th (in three weeks) if this doesn't happen.

(If there's no reason to avoid merging it, please do so. Otherwise, if it shouldn't be merged or if it needs more time, please close it or turn it into a draft.)

@SangwonOh
Copy link
Contributor

Ready to merge

@typescript-bot typescript-bot merged commit 1d02b4c into DefinitelyTyped:master Jun 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner Unmerged The author did not merge the PR when it was ready.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants