Update tape.d.ts for tape v4.2.2 #6976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tape/tape.d.ts to author (@Bartvds). Could you review this PR? Checklist
|
haoqunjiang
force-pushed
the
tape4
branch
2 times, most recently
from
82703f6
to
088c00c
Compare
| // Definitions: https://github.com/borisyankov/DefinitelyTyped | ||
|
|
||
| /// <reference path="../node/node.d.ts" /> | ||
|
|
||
| declare module 'tape' { | ||
| export = tape; | ||
| export default tape; |
There was a problem hiding this comment.
is this right?
https://github.com/substack/tape/blob/master/index.js#L19
tape does not have exports.default = module.exports; syntax.
export default tape; is not compatible export = tape;.
|
Oops. It's fixed now. |
haoqunjiang
force-pushed
the
tape4
branch
2 times, most recently
from
c935071
to
329dbc3
Compare
|
Just squashed to get a clean git history. |
vvakame
added a commit
that referenced
this pull request
Dec 10, 2015
Update tape.d.ts for tape v4.2.2
|
thanks mate! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/substack/tape