Skip to content

Commit

Permalink
Fix error occurring for guilds/users without icons
Browse files Browse the repository at this point in the history
Referencing #15
  • Loading branch information
Defxult committed Aug 6, 2022
1 parent 5547202 commit ab82ab0
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@
* `DiscordLevelingSystem.version_info()`
* Parameter `path` is now optional in method `DiscordLevelingSystem.create_database_file()`. If left as `None`, the database file is created in the current working directory.

#### Bug Fixes
* Fixed an issue where an error would occur when a user/guild doesn't have an icon. Now, the icon is the default discord user icon ([#5](https://github.com/Defxult/discordLevelingSystem/issues/15)).

<!-- </details> -->

## v1.1.0 » Jan. 29, 2022
Expand Down
9 changes: 5 additions & 4 deletions discordLevelingSystem/announcement.py
Original file line number Diff line number Diff line change
Expand Up @@ -175,12 +175,13 @@ def _convert_member_markdown(self, to_convert: str, message_author: DMember) ->
Added `discord.Member.display_avatar.url`
Added `discord.Member.banner.url`
"""
DEFAULT_URL = message_author.default_avatar.url
markdowns = {
# member
AnnouncementMember.avatar_url : message_author.avatar.url, # type: ignore / Possible `url` is `None` but that's ok
AnnouncementMember.banner_url : message_author.banner.url if message_author.banner is not None else None,
AnnouncementMember.avatar_url : message_author.avatar.url if message_author.avatar is not None else DEFAULT_URL,
AnnouncementMember.banner_url : message_author.banner.url if message_author.banner is not None else DEFAULT_URL,
AnnouncementMember.created_at : message_author.created_at,
AnnouncementMember.default_avatar_url : message_author.default_avatar.url,
AnnouncementMember.default_avatar_url : DEFAULT_URL,
AnnouncementMember.discriminator : message_author.discriminator,
AnnouncementMember.display_avatar_url : message_author.display_avatar.url,
AnnouncementMember.display_name : message_author.display_name,
Expand All @@ -191,7 +192,7 @@ def _convert_member_markdown(self, to_convert: str, message_author: DMember) ->
AnnouncementMember.nick : message_author.nick,

# guild
AnnouncementMember.Guild.icon_url : message_author.guild.icon.url, # type: ignore / Possible `url` is `None` but that's ok
AnnouncementMember.Guild.icon_url : message_author.guild.icon.url if message_author.guild.icon is not None else DEFAULT_URL,
AnnouncementMember.Guild.id : message_author.guild.id,
AnnouncementMember.Guild.name : message_author.guild.name
}
Expand Down

0 comments on commit ab82ab0

Please sign in to comment.