-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This resolves issue #146 in development_branch #170
This resolves issue #146 in development_branch #170
Conversation
This commit substitutes mpi_logical functions with integer analogues where needed.
Dear Egor, Wouldn't it be possible to replace MPI_LOGICAL8 with MPI_LOGICAL instead of MPI_INTEGER? Or, is it so that there is no MPI_LOGICAL at all in MPICH?
|
Yes, MPI_LOGICAL is always 8-byte long with -fdefault-integer-8 with gcc or -i8 with intel fortran compiler options. However we might just stick with 0 and 1 of type MPI_INTEGER8 as a substitution. My logic behind this decision was actually caused by an attempt to mimic your thought process you once told me: If MPI_INTEGER8 and MPI_REAL8 are our main types in Backup_Mod it may bother some users why exactly are we using MPI_LOGICAL and not MPI_LOGICAL8. |
…into development_branch
(only new values which are computed algebraically)
I had to make some assumtions in Const_K_Eps.f90
test_build.sh always failed "save_now" tests. This time the issue was in test_build.sh itself.
This pull request either substitutes MPI_LOGICAL8 functions with integer analogues where needed or removes them if not used anymore.
This safely solves issue #146 .