Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This resolves issue #146 in development_branch #170

Conversation

palkinev
Copy link
Collaborator

@palkinev palkinev commented Jan 13, 2020

This pull request either substitutes MPI_LOGICAL8 functions with integer analogues where needed or removes them if not used anymore.
This safely solves issue #146 .

This commit substitutes mpi_logical functions with integer
analogues where needed.
@palkinev palkinev requested a review from Niceno January 13, 2020 05:40
@palkinev palkinev self-assigned this Jan 13, 2020
@Niceno
Copy link
Collaborator

Niceno commented Jan 20, 2020

Dear Egor,

Wouldn't it be possible to replace MPI_LOGICAL8 with MPI_LOGICAL instead of MPI_INTEGER?

Or, is it so that there is no MPI_LOGICAL at all in MPICH?

Cheers,

 Bojan

@palkinev
Copy link
Collaborator Author

Yes,
'MPI_LOGICAL' is acceptable option, it always was as it is mentioned in issue #146 .

MPI_LOGICAL is always 8-byte long with -fdefault-integer-8 with gcc or -i8 with intel fortran compiler options.

However we might just stick with 0 and 1 of type MPI_INTEGER8 as a substitution.

My logic behind this decision was actually caused by an attempt to mimic your thought process you once told me:
“Someone will look inside the code and see those real*8 or real(kind=4) etc.
Instead we are going to have just ‘real’ type and it will always be set with double precision.”

If MPI_INTEGER8 and MPI_REAL8 are our main types in Backup_Mod it may bother some users why exactly are we using MPI_LOGICAL and not MPI_LOGICAL8.

@palkinev palkinev closed this May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants