Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add pypi release workflow #1146

Merged
merged 2 commits into from
Jun 1, 2024
Merged

ci: add pypi release workflow #1146

merged 2 commits into from
Jun 1, 2024

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Jun 1, 2024

how to use this:

create a pypi api token at https://pypi.org/manage/account/ and set project secret at https://github.com/Delgan/loguru/settings/secrets/actions , with name PYPI_API_TOKEN.

After it's done, change version and add a git tag, then push it to github.

Copy link
Owner

@Delgan Delgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, thanks for the quick PR.

with:
python-version: 3.x

- run: pipx run build
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use python -m build directly instead of pipx? Also, can we please add a twine check --strict dist/* step?

Copy link
Contributor Author

@trim21 trim21 Jun 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can't. build is not in stdlib and need to be installed with pip, which is what pipx run build do, pip install it and run it

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I suppose we just need to install it first. I'll add it to the tox.ini commands. Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I suppose we just need to install it first. I'll add it to the tox.ini commands. Thanks.

you don't need to add it...

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I certainly don't need to, but I prefer to regroup the commands and dependencies in one-place.

@Delgan
Copy link
Owner

Delgan commented Jun 1, 2024

I'll merge it as is, but for now it can't be used yet. I need to make the Readme compatible (it's not validated by Twine, I used to manually change a few things).

@Delgan Delgan merged commit cf7d2df into Delgan:master Jun 1, 2024
16 checks passed
@trim21 trim21 deleted the ci-release branch June 1, 2024 15:53
@trim21
Copy link
Contributor Author

trim21 commented Jun 19, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants