Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add pypi release workflow #1146

Merged
merged 2 commits into from
Jun 1, 2024
Merged

ci: add pypi release workflow #1146

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d5a940
ci: add pypi release workflow
trim21 Jun 1, 2024
9f42df3
Update release.yaml
trim21 Jun 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: release

on:
push:
tags:
- '*'

jobs:
release:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4

- uses: actions/setup-python@v5
with:
python-version: 3.x

- run: pipx run build
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use python -m build directly instead of pipx? Also, can we please add a twine check --strict dist/* step?

Copy link
Contributor Author

@trim21 trim21 Jun 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can't. build is not in stdlib and need to be installed with pip, which is what pipx run build do, pip install it and run it

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I suppose we just need to install it first. I'll add it to the tox.ini commands. Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I suppose we just need to install it first. I'll add it to the tox.ini commands. Thanks.

you don't need to add it...

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I certainly don't need to, but I prefer to regroup the commands and dependencies in one-place.


- run: pipx run twine upload dist/* --disable-progress-bar
env:
TWINE_USERNAME: __token__
TWINE_PASSWORD: ${{ secrets.PYPI_API_TOKEN }}
Loading