Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example stub for unit tests and stop download failures from breaking unit tests #41

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

mmiller-max
Copy link
Contributor

  • Add stubbed OSMGraph that can be used for unit tests without internet connection
  • Use stub throughout tests
  • Allow status errors to occur when downloading graphs (occurs in tests occasionally)

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2021

Codecov Report

Merging #41 (1604a28) into master (f1be1a9) will increase coverage by 1.57%.
The diff coverage is n/a.

❗ Current head 1604a28 differs from pull request most recent head 794a73e. Consider uploading reports for the commit 794a73e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   67.10%   68.67%   +1.57%     
==========================================
  Files          11       11              
  Lines         836      878      +42     
==========================================
+ Hits          561      603      +42     
  Misses        275      275              
Impacted Files Coverage Δ
src/geometry.jl 100.00% <ø> (ø)
src/types.jl 61.53% <0.00%> (-5.13%) ⬇️
src/download.jl 57.64% <0.00%> (-1.39%) ⬇️
src/traversal.jl 60.41% <0.00%> (-0.95%) ⬇️
src/parse.jl 74.33% <0.00%> (-0.67%) ⬇️
src/buildings.jl 0.00% <0.00%> (ø)
src/constants.jl 100.00% <0.00%> (ø)
src/utilities.jl 98.11% <0.00%> (+0.09%) ⬆️
src/shortest_path.jl 87.50% <0.00%> (+0.65%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1be1a9...794a73e. Read the comment docs.

Copy link
Collaborator

@captchanjack captchanjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/stub.jl Show resolved Hide resolved
@mmiller-max mmiller-max force-pushed the mm/add-stub branch 2 times, most recently from 672e92c to 1604a28 Compare August 26, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants