Stop shortest path returning no path when destination node is reached on suboptimal path #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
=======================================
Coverage 67.10% 67.10%
=======================================
Files 11 11
Lines 836 836
=======================================
Hits 561 561
Misses 275 275
Continue to review full report at Codecov.
|
|
Once #41 is in as I can add some explicit tests |
| @@ -69,10 +69,9 @@ function astar(g::AbstractGraph{U}, | |||
| H[v] = alt + heuristic(v, goal) | |||
There was a problem hiding this comment.
add description for heuristic usage in the doc string of shortest_path
mmiller-max
force-pushed
the
mm/shortest-path-fix
branch
from
b005cdf
to
cdd3023
Compare
mmiller-max
pushed a commit
that referenced
this pull request
Aug 30, 2021
mmiller-max
pushed a commit
that referenced
this pull request
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues that result from one bug
alt >= dists[v](for example if the last edge weight wasInfbutgoalwas still reached), thenparentswas returned fromastarbutparents[v]could be undefined, meaning that LightOSM errored with the no path exists messagealt < dists[v]) then the traversal would return this path, even if a better one existed.To solve the first, the early return was moved inside the
if alt < dists[v]statement, and to solve the second, the additional condition of checking that the goal is the first in the PriorityQueue enables this to be fixed without extra allocations/worsening performance.We may need to re-run the benchmarks