-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional location-related fields should not be written when empty #104
Comments
@rhutten, do you know whether it is "safe" to skip empty properties for all files? |
@arthurvd, I will change it to a bug, because we should not be serializing models to file that will raise error when deserialized again. Hope you agree with this :) |
priscavdsluis
added
type: bug
Something isn't working
and removed
type: enhancement
Improvements to existing functionality
labels
Sep 6, 2022
priscavdsluis
added a commit
that referenced
this issue
Sep 6, 2022
priscavdsluis
added a commit
that referenced
this issue
Sep 6, 2022
priscavdsluis
added a commit
that referenced
this issue
Sep 6, 2022
priscavdsluis
added a commit
that referenced
this issue
Sep 8, 2022
…r mdu and to True for the rest of the files.
priscavdsluis
added a commit
that referenced
this issue
Sep 27, 2022
priscavdsluis
added a commit
that referenced
this issue
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the .ext file, locations for Lateral and Boundary objects can be specified in multiple ways, so all these fields are optional.
When an MDU+ext file is saved to disk, also all optional fields are written, which is not an error, but it is unnecessarily confusing, nonetheless.
Example .ext input:
Currently saved output:
Note that the same issue arises for Structures (locations) and DamBreaks (waterlevel locations)
The text was updated successfully, but these errors were encountered: