Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Dambreak validation for waterlevel* fields #105

Closed
arthurvd opened this issue Oct 25, 2021 · 1 comment · Fixed by #266
Closed

Improve Dambreak validation for waterlevel* fields #105

arthurvd opened this issue Oct 25, 2021 · 1 comment · Fixed by #266
Assignees
@priscavdsluis
Projects
HYDROLIB-core

Comments

@arthurvd
Copy link
Member

The fields waterlevelupstreamlocationx/y and waterlevelupstreamnodeid are mutually exclusive.
Same for waterleveldownstreamlocationx/y and waterleveldownstreamnodeid.

Extra validation should check this.
@arthurvd arthurvd added this to To do in HYDROLIB-core via automation Oct 25, 2021
@priscavdsluis priscavdsluis moved this from To do to In progress in HYDROLIB-core Dec 10, 2021
@priscavdsluis priscavdsluis moved this from In progress to To do in HYDROLIB-core Dec 10, 2021
@priscavdsluis priscavdsluis moved this from To do to In progress in HYDROLIB-core Jun 28, 2022
priscavdsluis added a commit that referenced this issue Jun 28, 2022
@priscavdsluis
#105: Add water level location specification validation for DamBreaks.
ef24e08
priscavdsluis added a commit that referenced this issue Jun 28, 2022
@priscavdsluis
#105: Fix existing failing tests
0d2f08e
priscavdsluis added a commit that referenced this issue Jun 28, 2022
@priscavdsluis
#105: Update error message
b2252ac
priscavdsluis added a commit that referenced this issue Jun 28, 2022
@priscavdsluis
#105: Add test cases
b667cfe
@priscavdsluis priscavdsluis moved this from In progress to Ready to review in HYDROLIB-core Jun 28, 2022
@priscavdsluis priscavdsluis linked a pull request Jun 28, 2022 that will close this issue
#105: Add water level location validation DamBreaks #266
Merged
@priscavdsluis
Copy link
Contributor

Updated issue #104

@arthurvd arthurvd moved this from Ready to review to Reviewer follow up in HYDROLIB-core Jul 6, 2022
@priscavdsluis priscavdsluis moved this from Reviewer follow up to Ready to review in HYDROLIB-core Jul 7, 2022
HYDROLIB-core automation moved this from Ready to review to Done Jul 7, 2022
arthurvd pushed a commit that referenced this issue Jul 7, 2022
@priscavdsluis
fix: Add water level location validation DamBreaks
bbfe5a6 
* #105: Add water level location specification validation for DamBreaks.

* #105: Fix existing failing tests

* #105: Update error message

* #105: Add test cases

* autoformat: isort & black

Co-authored-by: priscavdsluis <priscavdsluis@users.noreply.github.com>

Refs: #105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@priscavdsluis priscavdsluis

Labels
None yet
Projects
HYDROLIB-core
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#105: Add water level location validation DamBreaks Deltares/HYDROLIB-core
2 participants
@arthurvd @priscavdsluis