Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement meteo for external forcing #446

Closed
xldeltares opened this issue Jan 30, 2023 · 4 comments · Fixed by #477
Closed

Implement meteo for external forcing #446

xldeltares opened this issue Jan 30, 2023 · 4 comments · Fixed by #477
Assignees
@priscavdsluis
Labels
type: feature Brand new functionality
Milestone
Release 0.5

Comments

@xldeltares
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
In project Santa Cruz, we need to implement rainfall on 2D grid as meteo forcing. For now hydrolib-core does not have the meteo implemented.

Describe the solution you'd like
a new class Meteo(INIBasedModel) that writes a [Meteo] block for use inside an external forcings file.
@xldeltares xldeltares added the type: feature Brand new functionality label Jan 30, 2023
@xldeltares xldeltares self-assigned this Feb 9, 2023
@xldeltares xldeltares mentioned this issue Feb 9, 2023
Open
@arthurvd arthurvd assigned arthurvd and unassigned xldeltares Mar 22, 2023
@arthurvd
Copy link
Member

@xldeltares : I see you have (almost) implemented this already. Do you think you're ready to open a PR? I could review it/finish it for you in our current sprint.

@xldeltares
Copy link
Collaborator Author

@arthurvd: That would be great if you still could review/finish it in this sprint! I will create a PR and please feel free to work on it. Thanks!

@xldeltares xldeltares linked a pull request Mar 23, 2023 that will close this issue
#446: Implement meteo for external forcing #477
Merged
@arthurvd
Copy link
Member

@priscavdsluis / @tim-vd-aardweg / @MRVermeulenDeltares : our discussion about the diskOnlyFileModel will be continued under a new issue: #478.

@priscavdsluis
Copy link
Contributor

priscavdsluis commented Mar 28, 2023 •
edited
Loading

I reviewed the PR and the changes look good.
However there is the property forcing on the new Meteo object. I want to verify first if it is correct and find an example with non-global meteo data. 🚩

priscavdsluis added a commit that referenced this issue Apr 5, 2023
@priscavdsluis
#446: Add support for tim files in Meteo
e16ab46
@priscavdsluis priscavdsluis added this to the Release 0.5 milestone Apr 6, 2023
@priscavdsluis priscavdsluis removed the FLAG label Apr 7, 2023
@arthurvd arthurvd assigned priscavdsluis and unassigned arthurvd and xldeltares Apr 7, 2023
priscavdsluis added a commit that referenced this issue Apr 12, 2023
@priscavdsluis
#446: Fix a test and add two smaller tests.
af295ff
arthurvd pushed a commit that referenced this issue Apr 12, 2023
@xldeltares
feat: Support meteo blocks in external forcings file (#477)
b891b86 
Refs: #446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@priscavdsluis priscavdsluis

Labels
type: feature Brand new functionality
Projects
None yet
Milestone
Release 0.5
Development

Successfully merging a pull request may close this issue.

#446: Implement meteo for external forcing Deltares/HYDROLIB-core
3 participants
@arthurvd @priscavdsluis @xldeltares