Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network without face coordinates cannot be added to mdu #515

Closed
veenstrajelmer opened this issue Apr 6, 2023 · 1 comment · Fixed by #524
Closed

Network without face coordinates cannot be added to mdu #515

veenstrajelmer opened this issue Apr 6, 2023 · 1 comment · Fixed by #524
Labels
type: bug Something isn't working
Milestone

Comments

@veenstrajelmer
Copy link
Collaborator

Describe the bug
Network without face coordinates cannot be added to mdu. It is a valid network (and it is how the interacter writes them). However, adding them to the mdu raises: "KeyError: 'An attribute for "mesh2d_face_x" was not found in nc file. Expected "mesh2d_face_x"'"

To Reproduce

import hydrolib.core.dflowfm as hcdfm
mdu = hcdfm.FMModel()
netfile = 'network_nofacecoords_net.nc'
mdu.geometry.netfile = netfile

Expected behavior
If the network validation is not proper, it is better to do no network validation at al (at least temporarily). I think the mesh2d variable is not being read also and the variables are hardcoded.

Version info (please complete the following information):

  • OS: Windows
  • Version: hydrolib-core main branch

Additional context
The network:
network_nofacecoords_net.nc.txt

@priscavdsluis priscavdsluis added this to To do in HYDROLIB-core via automation Apr 11, 2023
@arthurvd arthurvd added the type: bug Something isn't working label Apr 12, 2023
@arthurvd arthurvd added this to the Release 0.5 milestone Apr 12, 2023
@arthurvd arthurvd moved this from To do to In progress in HYDROLIB-core Apr 12, 2023
@arthurvd arthurvd moved this from In progress to Ready to review in HYDROLIB-core Apr 12, 2023
@arthurvd
Copy link
Member

Already tested by @veenstrajelmer:

Jelmer — April 12, 2023 at 1:17 PM
Deze heb ik net getest en het werkt

@priscavdsluis priscavdsluis moved this from Ready to review to Review in progress in HYDROLIB-core Apr 12, 2023
@priscavdsluis priscavdsluis moved this from Review in progress to Ready to merge in HYDROLIB-core Apr 12, 2023
HYDROLIB-core automation moved this from Ready to merge to Done Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
HYDROLIB-core
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants