Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate MeshKernelPy >=3.0.0 #574

Merged
merged 79 commits into from
Nov 16, 2023

Conversation

veenstrajelmer
Copy link
Collaborator

@veenstrajelmer veenstrajelmer commented Oct 23, 2023

Meshkernel 3.0.0 was released on the 27th of October. This is great news since it contains many new and improved features. However, there are also some fundamental API changes. I tried my best to process them in this PR. The testbank is extended a bit and all green, which already took quite some effort. Mainly since the current code also did not work with meshkernel 2.1.0 but only 2.0.2 or maybe older. With the current changes, also the hydromt_delft3dfm testbank is green when using this hydrolib-core branch and some minor edits in the hydromt_delft3dfm code: Deltares/hydromt_delft3dfm#109

In short:

  • The Mesh2D class was trimmed down to avoid out of sync instances (mesh2d.mesh2d_node_x now comes from mesh2d.meshkernel.mesh2d_get().node_x)
  • The testbank was slightly extended
  • Secretly also added plotting to network class. If problematic for auto changelog generation, this can be done in a separate PR but this requires some extra administration. I needed the plotting to work in order to properly check the updated test results.

Follow-up issues (also mentioned in TODO comments in PR code):

@veenstrajelmer veenstrajelmer linked an issue Oct 23, 2023 that may be closed by this pull request

# bathymetry
node_z = self._read_nc_attribute(ds["mesh2d_node_z"])
mesh2d.mesh2d_node_z = node_z
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should face_z also be set?

@priscavdsluis priscavdsluis changed the title updated meshkernel API calls Integrate MeshKernelPy >=3.0.0 Nov 16, 2023
Copy link

sonarcloud bot commented Nov 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@priscavdsluis priscavdsluis merged commit ebe3815 into main Nov 16, 2023
2 checks passed
@priscavdsluis priscavdsluis deleted the 569-bumping-meshkernel-version-to-latest-v300 branch November 16, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants