Optional polygon parameter in contacts_compute_boundary api #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f mesh1d from the contacts computation Add test test_contacts_compute_boundary_with_no_polygon for testing contacts_compute_boundary with no polygon
meshkernel/meshkernel.py
Outdated
| ) -> None: | ||
| """Computes Mesh1d-Mesh2d contacts, where Mesh1d nodes are connected to the closest Mesh2d faces at the boundary | ||
|
|
||
| Args: | ||
| node_mask (ndarray): A boolean array describing whether Mesh1d nodes should or | ||
| should not be connected | ||
| points (GeometryList): The points selecting the Mesh2d faces to connect. | ||
| points (GeometryList, optional): The points selecting the Mesh2d faces to connect. |
There was a problem hiding this comment.
Arg doc (points) does not correspond to actual method arg (polygons)
ahmad-el-sayed
requested changes
Oct 16, 2023
…optional_arguments
…f mesh1d from the contacts computation Add test test_contacts_compute_boundary_with_no_polygon for testing contacts_compute_boundary with no polygon
…hub.com/Deltares/MeshKernelPy into feature/GRIDEDIT-709_optional_arguments
ahmad-el-sayed
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.