Document listen_feature_type in DiscreteControl / condition

Also start requiring `listen_feature_type` since that is required by the code anyway

core/src/schema.jl

@@ -183,7 +183,7 @@ end
 
 @version DiscreteControlConditionV1 begin
     node_id::Int
-    listen_feature_type::Union{Missing, String}
+    listen_feature_type::String
     listen_feature_id::Int
     variable::String
     greater_than::Float64

docs/core/usage.qmd

@@ -603,13 +603,14 @@ DiscreteControl is implemented based on [VectorContinuousCallback](https://docs.
 
 The condition schema defines conditions of the form 'the discrete_control node with this node id listens to whether the given variable of the node with the given listen feature id is grater than the given value'. If the condition variable comes from a time-series, a look ahead $\Delta t$ can be supplied.
 
-column            | type     | unit    | restriction
------------------ | -------- | ------- | -----------
-node_id           | Int      | -       | sorted
-listen_feature_id | Int      | -       | sorted per node_id
-variable          | String   | -       | must be "level" or "flow_rate", sorted per listen_feature_id
-greater_than      | Float64  | various | sorted per variable
-look_ahead        | Float64  | $s$     | Only on transient boundary conditions, non-negative (optional, default 0)
+column              | type     | unit    | restriction
+-------------------  | -------- | ------- | -----------
+node_id             | Int      | -       | sorted
+listen_feature_id   | Int      | -       | sorted per node_id
+listen_feature_type | String   | -       | known node type
+variable            | String   | -       | must be "level" or "flow_rate", sorted per listen_feature_id
+greater_than        | Float64  | various | sorted per variable
+look_ahead          | Float64  | $s$     | Only on transient boundary conditions, non-negative (optional, default 0)
 
 ## DiscreteControl / logic
 

playground/output/ribasim.toml

@@ -0,0 +1,5 @@
+starttime = 2020-01-01 00:00:00
+endtime = 2021-01-01 00:00:00
+input_dir = "."
+results_dir = "results"
+ribasim_version = "2024.2.0"

python/ribasim/ribasim/schemas.py

@@ -50,7 +50,7 @@ class BasinTimeSchema(_BaseSchema):
 
 class DiscreteControlConditionSchema(_BaseSchema):
     node_id: Series[int] = pa.Field(nullable=False)
-    listen_feature_type: Series[str] = pa.Field(nullable=True)
+    listen_feature_type: Series[str] = pa.Field(nullable=False)
     listen_feature_id: Series[int] = pa.Field(nullable=False)
     variable: Series[str] = pa.Field(nullable=False)
     greater_than: Series[float] = pa.Field(nullable=False)