Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rutter interception #300

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Fix rutter interception #300

merged 4 commits into from
Sep 5, 2023

Conversation

verseve
Copy link
Member

@verseve verseve commented Sep 1, 2023

Issue addressed

Fixes #299

Explanation

The amount of computed throughfall and stemflow in the modified Rutter interception model could become larger than the precipitation input (water balance issue), because the sum of the stemflow partitioning coefficient pt and free throughfall coefficient p could get larger than 1. In addition, the net interception (netinterception) was not computed correctly: the first drainage term dd was subtracted from precipitation (as part of throughfall), while dd is controlled by a change in the canopy storage capacity cmax over time (e.g. because of a change in leaf area index LAI), and thus not part of the precipitation input. This could result in a negative netinterception:

netinterception = precipitation - throughfall - stemflow

Finally, the interception (interception loss through evaporation) output from the modified Rutter interception model should be stored in SBM, and not netinterception. The interception loss through evaporation is used to compute total actual evapotranspiration (actevap).

Checklist

  • Branch is up to date with master
  • Tests & pre-commit hooks pass
  • Updated documentation if needed
  • Updated changelog.md if needed

- The `interception` output (interception loss by evaporation) from the modified Rutter interception model should be used in `SBM`, also as input for the computation of total actual evapotranspiration `actevap`.
- Update of docs and changelog.
@JoostBuitink
Copy link
Contributor

Thanks for addressing this issue; the proposed changes look good to me! I have made some small changes to the names of the variables, in order to make the code a bit more readable. Let me know if you agree with these changes or not!

@verseve
Copy link
Member Author

verseve commented Sep 5, 2023

I have made some small changes to the names of the variables, in order to make the code a bit more readable. Let me know if you agree with these changes or not!

I agree with the changes to the variable names!

@verseve verseve merged commit d0e35c4 into master Sep 5, 2023
11 of 12 checks passed
@verseve verseve deleted the fix_rutter_interception branch September 11, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Water balance Rutter interception model
2 participants