Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HydroMT API (for HydroMT-dash) #118

Merged
merged 16 commits into from
Sep 20, 2022
Merged

HydroMT API (for HydroMT-dash) #118

merged 16 commits into from
Sep 20, 2022

Conversation

DirkEilander
Copy link
Contributor

@DirkEilander DirkEilander commented Apr 13, 2022

API methods:

  • get_model_components
  • get_datasets
  • get_predefined_catalogs
  • Added entrypoints for new submodel classes

@codecov-commenter
Copy link

Codecov Report

Merging #118 (cb06cc4) into main (f8197d8) will decrease coverage by 0.65%.
The diff coverage is 3.22%.

@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
- Coverage   83.79%   83.13%   -0.66%     
==========================================
  Files          22       23       +1     
  Lines        3831     3861      +30     
==========================================
  Hits         3210     3210              
- Misses        621      651      +30     
Impacted Files Coverage Δ
hydromt/api.py 0.00% <0.00%> (ø)
hydromt/models/model_api.py 87.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8197d8...cb06cc4. Read the comment docs.

@DirkEilander DirkEilander marked this pull request as ready for review August 24, 2022 14:56
Copy link
Contributor

@hboisgon hboisgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice additions!
Good to merge now to have the functions available for the dashboard but some things to remember for future improvements:

  • _EXPECTED_TYPES in get_model_components: make sure the list is full (exemple list and tuple are not in)
  • Types in get_model_components allow exceptions for Union but not for Optional. For Union 1st keyword is used but sometimes can be list of str or single str

@DirkEilander DirkEilander merged commit a2998cf into main Sep 20, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants