-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HydroMT API (for HydroMT-dash) #118
Conversation
Codecov Report
@@ Coverage Diff @@
## main #118 +/- ##
==========================================
- Coverage 83.79% 83.13% -0.66%
==========================================
Files 22 23 +1
Lines 3831 3861 +30
==========================================
Hits 3210 3210
- Misses 621 651 +30
Continue to review full report at Codecov.
|
…on for retrieving datasets from data catalog #127
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice additions!
Good to merge now to have the functions available for the dashboard but some things to remember for future improvements:
- _EXPECTED_TYPES in get_model_components: make sure the list is full (exemple list and tuple are not in)
- Types in get_model_components allow exceptions for Union but not for Optional. For Union 1st keyword is used but sometimes can be list of str or single str
API methods: