-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new GeoDataset #208
Closed
Closed
new GeoDataset #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@hboisgon Could you already have a look a the implementation and let me know what you agree with the approach? |
3 tasks
I did write a unit test for an ogr compliant dataset. Maybe now or in the near future, rename the registration from 'geo' to 'vector' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new implementation of the GeoDataset allows for any geometry type (not only points) to be combined with multi-dimensional data. My suggestion is to develop it next the current implementation which we will remove in a future release.
TODO:
Related issue: #177
Goal
implementation notes:
Types of dataset on which the accessor should work:
Notes on geometry object
Right now the geometries are saved in the
geometry
object of the GeoDataset as a geopandas.array.GeoArray which is a numpy duck array type with additional geometry methods. This does not yet implement the__array__function__
method and can therefore not yet be integrated into a coordinate or variable of a xarray Dataset. Instead in an xarray Dataset it is reduced to a normal numpy objects array.