New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update methods around gauges #172
Conversation
I think this PR is more or less ready to be merged. Because I added a new create_gauges method, I wonder if we include it in the next release or wait for this issue to be fixed in hydromt core before merging: Deltares/hydromt#312 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work @hboisgon !!!
I have only some very very minor suggestions, more in terms of additional details in the documentation.
I tested the new snapping option based on area using data from a project and it works very well, nice implementation! also great that there are now more possibilities for the gauges_fn format.
the tests are also running for me, so I think after checking these minor comments, it is ready to merge!
Hi @laurenebouaziz ! Thanks a lot for the review! I added better docstrings, you were absolutely right :) and I answered some of your questions here too. Could you re-review and see if the changes I made are good? |
thanks @hboisgon for the clear docstrings and all the explanations to the questions I had, all clear to me. Apart from the last tiny comment, I think it is good to merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks @hboisgon for all these nice new additions!
Based on several open issues, this PR contains several changes associated to gauges: