Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regrid_like method to MetaSWAP object #365

Closed
Manangka opened this issue May 15, 2023 · 2 comments
Closed

Add regrid_like method to MetaSWAP object #365

Manangka opened this issue May 15, 2023 · 2 comments
Assignees
Labels
backwards_compatibility Backwards compatibility with iMOD5 story

Comments

@Manangka
Copy link
Collaborator

Manangka commented May 15, 2023

In GitLab by @JoerivanEngelen on May 15, 2023, 17:16

New from the Modflow 6 implementation is that we have to regrid integer arrays, which probably requires some thinking (Downscaling with "nearest", upscaling with "count"?).

Refinement

  • For testing, ideally, this would be used Add test for MetaSWAP that runs a model #971
  • For now, we can use test script, also described in that issue or juste purely unit test if files are written as expected.,
  • Ideally, we work towards using a shared base class between Modflow 6 Model and MetaSWAP model
  • Has to be investigated if feasable, we can implement and duplicate code where necessary.

Update:

After working on this issue, the scope has been reduced and new issues will be created to address the remaining parts.
The new scope is:
-implement regridding for "easy"packages, specifically
-Infiltration
-Initial conditions
-LandUse
-Ponding
-ScalingFactors
-Vegetation
-add tests for regridding these packagews

@JoerivanEngelen JoerivanEngelen changed the title Add regrid_like method to MetaSWAP and MetaMod object Add regrid_like method to MetaSWAP object Apr 9, 2024
@JoerivanEngelen
Copy link
Contributor

Update:

We do not add regridding to MetaMod, as this would entail chaning things in primod, I think we can ask from users to initiate the MetaMod object again after regridding their Modflow6 simulation and MetaSWAP model.

luitjansl added a commit that referenced this issue Apr 30, 2024
Fixes #365

# Description
Adds regrid functionality to a number of metaswap packages
Adds unittests for regridding these packages

# Checklist

- [X] Links to correct issue
- [ ] Update changelog, if changes affect users
- [X] PR title starts with ``Issue #nr``, e.g. ``Issue #737``
- [X] Unit tests were added
- [ ] **If feature added**: Added/extended example
@JoerivanEngelen
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards_compatibility Backwards compatibility with iMOD5 story
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants