Fix cognitive complexity warning in news_shortcodes::sc_newsnavlink()

Deltik · Nov 30, 2020 · c0db790 · c0db790
1 parent ef06f38
commit c0db790
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/e107_core/shortcodes/batch/news_shortcodes.php b/e107_core/shortcodes/batch/news_shortcodes.php
@@ -202,7 +202,8 @@ function sc_trackback($parm=null)
 	 */
 	function sc_newsnavlink($parm=null) //TODO add more options.
 	{
-
+		$url = e107::getUrl()->create('news/list/items'); // default for now.
+
 		if(varset($parm['list']) == 'all') // A list of all items - usually headings and thumbnails
 		{
 			$url = e107::getUrl()->create('news/list/all');
@@ -215,12 +216,7 @@ function sc_newsnavlink($parm=null) //TODO add more options.
 		{
 			$url = e107::getUrl()->create('news/list/category', $this->news_item); 		
 		}
-		else
-		{
-			$url = e107::getUrl()->create('news/list/items'); // default for now. 	
-		}
-
-
+
 		$caption = vartrue($parm['text'],LAN_BACK);
 
 		$text = '<ul class="pager hidden-print">