Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Multi-location support for Events #933

Merged
merged 18 commits into from
Jan 25, 2023
Merged

Conversation

marlonkeating
Copy link
Contributor

@marlonkeating marlonkeating commented Dec 1, 2022

closes #932

Addendum: Updated annual report link on About page

@marlonkeating marlonkeating temporarily deployed to democracy-lab-staging December 1, 2022 19:32 Inactive
@marlonkeating marlonkeating temporarily deployed to democracy-lab-staging December 4, 2022 18:27 Inactive
@marlonkeating marlonkeating changed the title Add EventLocationTimeZone model Add Multi-location support for Events Dec 9, 2022
@marlonkeating marlonkeating temporarily deployed to democracy-lab-staging January 7, 2023 07:10 Inactive
@marlonkeating marlonkeating temporarily deployed to democracy-lab-staging January 9, 2023 06:44 Inactive
@marlonkeating marlonkeating marked this pull request as ready for review January 9, 2023 09:54
@marlonkeating marlonkeating temporarily deployed to democracy-lab January 9, 2023 09:57 Inactive
@marlonkeating marlonkeating temporarily deployed to democracy-lab-staging January 12, 2023 01:05 Inactive
@marlonkeating marlonkeating temporarily deployed to democracy-lab January 12, 2023 05:45 Inactive
@marlonkeating marlonkeating linked an issue Jan 12, 2023 that may be closed by this pull request
@marlonkeating marlonkeating temporarily deployed to democracy-lab-staging January 24, 2023 03:43 Inactive
@marlonkeating marlonkeating temporarily deployed to democracy-lab January 24, 2023 04:16 Inactive
Copy link
Collaborator

@PeterBreen PeterBreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the one item pushed to a future PR (sort by TZ on event page) everything worked for me, including the admin console, project owner, and volunteer flows.

The only error state I ran into involved an event created on a previous branch and then edited on this one, but I can't replicate it so I can't say it blocks anything. At most, I'd say keep an eye out to see if old events might not handle new features gracefully.

@marlonkeating marlonkeating merged commit 51a64bc into master Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blank Screen on Edit Project of Event Multi-location support for Events
2 participants