Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments connector is sometimes duplicated #1340

Closed
franciclo opened this issue Dec 7, 2016 · 0 comments
Closed

Comments connector is sometimes duplicated #1340

franciclo opened this issue Dec 7, 2016 · 0 comments
Assignees
@franciclo
Labels
bug

Comments

@franciclo
Copy link
Contributor

franciclo commented Dec 7, 2016 •
edited

When the comments connector returns the pending state, and then the fullfilled state, it seems that a null cache is being hooked when an action is triggered.
To reproduce put log in the function passed to the connect function, and refresh the page till you see two logs (doesn't happen often) and every action will cause to clear all comments because the cache is empty.
@franciclo franciclo added the bug label Dec 7, 2016
@franciclo franciclo added this to the Add React - Update views management milestone Dec 7, 2016
@mjlescano mjlescano changed the title Comments disapear but one Comments disappear but one Dec 14, 2016
@franciclo franciclo self-assigned this Dec 20, 2016
@franciclo franciclo changed the title Comments disappear but one Comments connector is sometimes duplicated Dec 20, 2016
franciclo added a commit that referenced this issue Dec 21, 2016
@franciclo
fix comments cache Closes #1340
25ff2df
mjlescano pushed a commit that referenced this issue Jan 27, 2017
@franciclo @mjlescano
fix comments cache Closes #1340
67e4baf
mjlescano pushed a commit that referenced this issue Mar 23, 2017
@franciclo @mjlescano
fix comments cache Closes #1340
008c402
mjlescano pushed a commit that referenced this issue Mar 23, 2017
@franciclo @mjlescano
fix comments cache Closes #1340
982a8bc
@gvilarino gvilarino mentioned this issue May 17, 2022
Open
@snyk-bot snyk-bot mentioned this issue May 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@franciclo franciclo

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@franciclo