Bugfix: Child id can be smaller than parent id #26
+270
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jesusisao can we cover the |
jesusisao
commented
Dec 10, 2020
spec/invalid-tree-spec.js
Outdated
| expect( node[key_parent] ).toBe(0); | ||
| expect( key_child in node ).toBe(true); | ||
| expect( node[key_child].length ).toBe(2); | ||
| expect( node[depthKeyName] ).toBe(0); |
There was a problem hiding this comment.
@DenQ
I added a depth test like this
jesusisao
commented
Dec 10, 2020
spec/invalid-tree-spec.js
Outdated
| parent: 101 // bad id | ||
| }, { | ||
| id: 10, | ||
| parent: 102 // bad id |
There was a problem hiding this comment.
I also added a test if it was an invalid list.
(To prevent the recursive function from going into an infinite loop)
|
@jesusisao i will look soon. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature
This PR allows users to use smaller child id than parent id.
#27
how
Achieved by adding "__depth" key and using it in sorting.
before:
after:
I'm not good at English, so I'm sorry if it's rude