Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mapzen provider #156

Closed
DenisCarriere opened this issue Sep 17, 2015 · 4 comments
Closed

Add Mapzen provider #156

DenisCarriere opened this issue Sep 17, 2015 · 4 comments
Assignees

Comments

@DenisCarriere
Copy link
Owner

https://gist.github.com/sbma44/c005070ac76ece6aa259

@stirringhalo
Copy link
Contributor

I'll have a couple pulls tonight for this one.

@stirringhalo
Copy link
Contributor

Question Denis, I have Mapzen mostly working. However, when it fails to find a search result, the API returns:

{"type":"FeatureCollection","features":[],"date":1445969167316}

I'm not sure how best to handle this in mapzen.py (https://raw.githubusercontent.com/stirringhalo/geocoder/master/geocoder/mapzen.py). It ends up crashing on getattrs later on. I see Yandex.py needs similar handling but I cannot figure out how it does so.

Thanks!

@DenisCarriere
Copy link
Owner Author

@stirringhalo Perfect thanks! I'm going time to review it, so whenever that pull request comes in I will make sure it works.

@ebreton
Copy link
Collaborator

ebreton commented Sep 10, 2017

It looks like Mapzen works now. At least, the tests are passing for geocoding, reverse and multiple results 👍

Closing the ticket !

@ebreton ebreton closed this as completed Sep 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants