Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tamu docs, Tamu CLI, test_cli.py, parallelize tests #185

Merged
merged 21 commits into from Apr 7, 2016

Conversation

ac6y
Copy link
Contributor

@ac6y ac6y commented Apr 6, 2016

Hi Dennis,
Added a few more commits - mostly docs for Tamu provider, tamu cli support and some tests:

  • added dev-requirement pytest-xdist (so tests can run in parallel)
  • updated Makefile to do same tests as Travis, and add "-n auto" to parallelize
  • add cli param support for tamu (might need some of these for other providers too?)
  • add test_cli.py module to test cli call functionality, (just tamu and default tests added initially)
  • merged AUTHORS.rst and docs/authors.rst and replaced AUTHORS.rst with symlink to docs/authors.rst

Other stuff still ToDo:

  • add cli param support if needed for other providers (assuming the way we're doing this is ok)
  • add cli tests to test_cli.py for other providers

Cheers,
Michael

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 74.334% when pulling eab0326 on ac6y:master into 321e98c on DenisCarriere:master.

@@ -7,7 +7,7 @@ init:
pip install -r requirements.txt

test:
py.test test_geocoder.py --verbose
py.test tests --doctest-modules --pep8 geocoder -v --cov geocoder --cov-report term-missing
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glade you made this edit~! 👍

@DenisCarriere
Copy link
Owner

Awesome work Michael! Great job, thanks for adding all the extra documentation for Tamu.

Cheers! 👍

@DenisCarriere DenisCarriere merged commit 3b01386 into DenisCarriere:master Apr 7, 2016
@ac6y
Copy link
Contributor Author

ac6y commented Apr 7, 2016

Thank you Denis! It's a pleasure to be able to contribute :)

Cheers,
Michael
:mobile:
On Apr 7, 2016 1:04 PM, "Denis" notifications@github.com wrote:

Awesome work Michael! Great job, thanks for adding all the extra
documentation for Tamu.

Cheers! [image: 👍]


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#185 (comment)

@DenisCarriere
Copy link
Owner

The docs are updated on the Geocoder page.
https://geocoder.readthedocs.org/providers/Tamu.html

@DenisCarriere
Copy link
Owner

@ac6y Do you have a Twitter account? I couldn't find you. I posted this as a mention.
https://twitter.com/DenisCarriere/status/718173552474722304

@ac6y
Copy link
Contributor Author

ac6y commented Apr 7, 2016

No, I've been meaning to get a Twitter account, but haven't yet. Thanks for
the mention tweet!

Cheers,
Michael
:mobile:
On Apr 7, 2016 1:30 PM, "Denis" notifications@github.com wrote:

@ac6y https://github.com/ac6y Do you have a Twitter account? I couldn't
find you. I posted this as a mention.
https://twitter.com/DenisCarriere/status/718173552474722304


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#185 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants