Skip to content

Commit

Permalink
Save some string abuse in dMaterial
Browse files Browse the repository at this point in the history
  • Loading branch information
mcmonkey4eva committed Mar 21, 2015
1 parent 7588e0b commit 95c8c49
Showing 1 changed file with 10 additions and 8 deletions.
18 changes: 10 additions & 8 deletions src/main/java/net/aufdemrand/denizen/objects/dMaterial.java
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,7 @@ public static void _initialize() {
// dMaterials that are registered as a 'variety' will need to identify as
// something more specific than the traditional enum/data information.
private String forcedIdentity = null;
private String forcedIdentityLow = null;

/**
* Forces the dMaterial to identify as something other than the enum value
Expand All @@ -457,6 +458,7 @@ public static void _initialize() {
*/
private dMaterial forceIdentifyAs(String string) {
forcedIdentity = string;
forcedIdentityLow = CoreUtilities.toLowerCase(string);
return this;
}

Expand Down Expand Up @@ -697,36 +699,36 @@ public String getObjectType() {

@Override
public String identify() {
if (forcedIdentity != null) return "m@" + forcedIdentity.toLowerCase();
if (forcedIdentity != null) return "m@" + forcedIdentityLow;
if (getData() != null && getData() > 0) return "m@" + material.name().toLowerCase() + "," + getData();
return "m@" + material.name().toLowerCase();
}

public String identifyFull() {
if (forcedIdentity != null) return "m@" + forcedIdentity.toLowerCase() + (getData() != null ? "," + getData(): "");
if (forcedIdentity != null) return "m@" + forcedIdentityLow + (getData() != null ? "," + getData(): "");
if (getData() != null) return "m@" + material.name().toLowerCase() + "," + getData();
return "m@" + material.name().toLowerCase();
}

@Override
public String identifySimple() {
if (forcedIdentity != null) return "m@" + forcedIdentity.toLowerCase();
if (forcedIdentity != null) return "m@" + forcedIdentityLow;
return "m@" + material.name().toLowerCase();
}

public String identifyNoIdentifier() {
if (forcedIdentity != null) return forcedIdentity.toLowerCase();
if (forcedIdentity != null) return forcedIdentityLow;
if (getData() != null && getData() > 0) return material.name().toLowerCase() + "," + getData();
return material.name().toLowerCase();
}

public String identifySimpleNoIdentifier() {
if (forcedIdentity != null) return forcedIdentity.toLowerCase();
if (forcedIdentity != null) return forcedIdentityLow;
return material.name().toLowerCase();
}

public String identifyFullNoIdentifier() {
if (forcedIdentity != null) return forcedIdentity.toLowerCase() + (getData() != null ? "," + getData(): "");
if (forcedIdentity != null) return forcedIdentityLow + (getData() != null ? "," + getData(): "");
if (getData() != null) return material.name().toLowerCase() + "," + getData();
return material.name().toLowerCase();
}
Expand All @@ -737,7 +739,7 @@ public String toString() {
}

public String realName() {
if (forcedIdentity != null) return forcedIdentity.toLowerCase();
if (forcedIdentity != null) return forcedIdentityLow;
return material.name().toLowerCase();
}

Expand Down Expand Up @@ -903,7 +905,7 @@ else return new Element(material == compared.getMaterial())
// Returns the name of the material.
// -->
if (attribute.startsWith("name"))
return new Element(forcedIdentity != null ? forcedIdentity.toLowerCase():
return new Element(forcedIdentity != null ? forcedIdentityLow:
material.name().toLowerCase())
.getAttribute(attribute.fulfill(1));

Expand Down

0 comments on commit 95c8c49

Please sign in to comment.