Implement attachable tripwire mechanism and tags #2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tal5
reviewed
Mar 17, 2023
| @@ -8,9 +8,13 @@ | |||
| import com.denizenscript.denizencore.objects.ObjectTag; | |||
| import com.denizenscript.denizencore.objects.properties.Property; | |||
| import com.denizenscript.denizencore.objects.properties.PropertyParser; | |||
| import net.citizensnpcs.util.NMS; | |||
tal5
reviewed
Mar 17, 2023
| @@ -53,6 +55,7 @@ public static void register() { | |||
| // For a lantern, this returns whether it is hanging from the ceiling. | |||
| // For a gate, this returns whether it is lowered to attach to a wall block. | |||
| // For a mangrove_propagule, this returns whether it is hanging from the block above it. | |||
| // For a tripwire, denotes whether a tripwire hook or string forms a complete tripwire circuit and is ready to trigger. | |||
There was a problem hiding this comment.
Should follow the format the rest of the entries above use, e.g. this returns whether...
|
Do not manually click "Resolve", that is a button for me/aya to use not a PR author |
...in/src/main/java/com/denizenscript/denizen/objects/properties/material/MaterialAttached.java
Show resolved
Hide resolved
| @@ -129,6 +147,10 @@ public void adjust(Mechanism mechanism) { | |||
| // For a lantern, this sets whether it is hanging from the ceiling. | |||
| // For a gate, this sets whether it is lowered to attach to a wall block. | |||
| // For a mangrove_propagule, this sets whether it is hanging from the block above it. | |||
| // For a tripwire, this sets whether a tripwire hook or string forms a complete tripwire circuit and is ready to trigger. | |||
| // Updating the property on a tripwire hook will change the texture to indicate a connected string, but will not have | |||
| // any effect when used on the tripwire string itself. It may however still be used to check whether the string forms a circuit. | |||
There was a problem hiding this comment.
These lines are split really awkwardly. If you must insert a newline, place it after a period or a comma, not just in the middle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tripwire and tripwirehook support to attachable as requested by ULSTICK on Discord: https://discord.com/channels/315163488085475337/1086271537872633937/1086271537872633937
Written with help from @tal5 and tested to be working successfully