reenable cppcheck for rosbag2_transport (ros2#461)

* reenable cppcheck Signed-off-by: Karsten Knese <karsten@openrobotics.org> * suppress unknown macro inline Signed-off-by: Karsten Knese <karsten@openrobotics.org>
DensoADAS · Jul 17, 2020 · 8e71e9c · 8e71e9c
1 parent a67ed49
commit 8e71e9c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/rosbag2_transport/CMakeLists.txt b/rosbag2_transport/CMakeLists.txt
@@ -183,8 +183,6 @@ if(BUILD_TESTING)
   find_package(test_msgs REQUIRED)
   find_package(rosbag2_test_common REQUIRED)
   include(cmake/rosbag2_transport_add_gmock.cmake)
-  # explicitly disable cppcheck
-  set(ament_cmake_cppcheck_FOUND TRUE)
   ament_lint_auto_find_test_dependencies()
   call_for_each_rmw_implementation(create_tests_for_rmw_implementation)
 endif()

diff --git a/rosbag2_transport/src/rosbag2_transport/generic_subscription.hpp b/rosbag2_transport/src/rosbag2_transport/generic_subscription.hpp
@@ -35,6 +35,7 @@ namespace rosbag2_transport
 class GenericSubscription : public rclcpp::SubscriptionBase
 {
 public:
+  // cppcheck-suppress unknownMacro
   RCLCPP_SMART_PTR_DEFINITIONS(GenericSubscription)
 
   /**
@@ -73,6 +74,7 @@ class GenericSubscription : public rclcpp::SubscriptionBase
   const rclcpp::QoS & qos_profile() const;
 
 private:
+  // cppcheck-suppress unknownMacro
   RCLCPP_DISABLE_COPY(GenericSubscription)
 
   std::shared_ptr<rclcpp::SerializedMessage> borrow_serialized_message(size_t capacity);