Use context.File for unencrypted downloads #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribut
force-pushed
the
unencrypted-use-file
branch
from
4409984
to
151c44a
Compare
This is faster than io.copy, allows the clients to show progress (emits the Content-Length header) and also enables resuming (supports the Range header - cf Depado#28). This commit also reduces the amount of duplicated code between View() and Head().
tribut
force-pushed
the
unencrypted-use-file
branch
from
151c44a
to
390ce07
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is faster than io.copy, allows the clients to show progress (emits the Content-Length header) and enables resuming (supports the Range header - cf #28).
This commit also reduces the amount of duplicated code between View() and Head().