Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue tokens for project cloning #2842

Closed
2 tasks done
WDN2010 opened this issue Jun 22, 2023 · 3 comments · Fixed by #3260
Closed
2 tasks done

Queue tokens for project cloning #2842

WDN2010 opened this issue Jun 22, 2023 · 3 comments · Fixed by #3260
Labels
enhancement New feature or request
Milestone

Comments

@WDN2010
Copy link

WDN2010 commented Jun 22, 2023

Current Behavior

API request "PUT /v1/project/clone" returns response 200 with new project UUID like if operation is finished
In fact, cloning a project is a continuous process that requires copying information about the components in use from the original repository to the new
That can lead to problems like #2768 when running two continuous operations at the same time leads to unwanted results

Proposed Behavior

Return status token like PUT /v1/bom does.
This allows to track cloning process and sync task order for Dependency Track to aviod timing conflicts

Checklist

@WDN2010 WDN2010 added the enhancement New feature or request label Jun 22, 2023
@nscuro
Copy link
Member

nscuro commented Nov 13, 2023

Additional note: Cloning is currently not executed in a single transaction, so it's possible that a failure leaves behind an incompletely cloned project. This is sub-optimal as it is hard to detect without accessing the logs. This needs to be addressed by wrapping the entire procedure into a single database transaction.

@rkg-mm
Copy link
Contributor

rkg-mm commented Dec 3, 2023

@nscuro I did not find a way to implement the transaction part but the token I was able to do. not sure how transactions would work while wanting to use the existing token process of the event system?

nscuro added a commit that referenced this issue Dec 8, 2023
…oning

Return processing token when cloning project #2842
@nscuro nscuro added this to the 4.11 milestone Dec 8, 2023
Copy link
Contributor

github-actions bot commented Jan 8, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants