Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return processing token when cloning project #2842 #3260

Merged

Conversation

rkg-mm
Copy link
Contributor

@rkg-mm rkg-mm commented Dec 3, 2023

Description

Return a token when cloning projects which can be used to query clone processing status.
Add an endpoint to query clone processing status.

Addressed Issue

Closes #2842

Additional Details

I did not find an obvious way to also implement wrapping cloning in a transaction while using the processing tokens, so this part is not implemented.

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

…y token processing status.

Signed-off-by: Ralf King <rkg@mm-software.com>
Signed-off-by: Ralf King <rkg@mm-software.com>
@rkg-mm
Copy link
Contributor Author

rkg-mm commented Dec 3, 2023

not sure why the unit test fails now, it works locally and I see no reason why It should not

@nscuro nscuro added this to the 4.11 milestone Dec 3, 2023
Make existing Bom token resource deprecated in favour of the new one.

Signed-off-by: Ralf King <rkg@mm-software.com>
@nscuro
Copy link
Member

nscuro commented Dec 4, 2023

not sure why the unit test fails now, it works locally and I see no reason why It should not

Seems to be flaky, it's failing on other PRs as well. I'll have a look.

Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rkg-mm!

@nscuro nscuro added the enhancement New feature or request label Dec 8, 2023
@nscuro nscuro merged commit a0ca1ab into DependencyTrack:master Dec 8, 2023
9 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Queue tokens for project cloning
2 participants