Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unmount apfs volumes before deleting them #662

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Unmount apfs volumes before deleting them #662

merged 1 commit into from
Oct 3, 2023

Conversation

Hoverbear
Copy link
Contributor

Description

Hopefully fixes #647

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@Hoverbear Hoverbear added the upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing label Oct 2, 2023
@Hoverbear Hoverbear added this to the 0.13.1 milestone Oct 2, 2023
@Hoverbear Hoverbear requested a review from cole-h October 2, 2023 18:35
@Hoverbear Hoverbear self-assigned this Oct 2, 2023
@Hoverbear Hoverbear mentioned this pull request Oct 2, 2023
Closed
@Hoverbear Hoverbear merged commit 25ed45f into main Oct 3, 2023
13 of 14 checks passed
@Hoverbear Hoverbear deleted the hoverbear/ds-1275-macos-uninstaller-should-unmount-nix-store-before-deleting branch October 3, 2023 17:07
This was referenced May 23, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees

@Hoverbear Hoverbear

Labels
upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing
Projects
None yet
Milestone
0.13.1
Development

Successfully merging this pull request may close these issues.

macOS: uninstaller should unmount Nix Store before deleting it
2 participants
@Hoverbear @cole-h