Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow inputs for type = "flake" #75

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ma27
Copy link

@Ma27 Ma27 commented Nov 14, 2021

Description

Needed for Hydra instances using NixOS/hydra#922

Note: please don't merge until the linked PR is accepted in nixos/hydra :)

Checklist
  • Built with make build
  • Formatted with make fmt
  • Verifed the example configuration still parses with terraform init && terraform validate (you may need to make install from the root of the project)
  • Ran acceptance tests with HYDRA_HOST=http://0.0.0.0:63333 HYDRA_USERNAME=alice HYDRA_PASSWORD=foobar make testacc (you will need to spin up a local / temporary instance of Hydra)
  • Added or updated relevant documentation (leave unchecked if not applicable)

Needed for Hydra instances using NixOS/hydra#922
@grahamc
Copy link
Member

grahamc commented Nov 15, 2021

I'm a bit surprised there aren't failing tests, but perhaps there are and they aren't caught by CI. Looks like a good patch once hydra#922 is merged, thanks!

@Ma27
Copy link
Author

Ma27 commented Nov 26, 2021

I see :) is there anything else tbd to get this (and previously hydra#922) merged? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants