-
-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying jobset inputs for flake builds for Hydra plugins #922
base: master
Are you sure you want to change the base?
Conversation
also CCing @edolstra whoi originally implemented flake support for Hydra. |
4292d49
to
18ff0c7
Compare
I'm not sure it is a good idea to bring back jobset inputs like this. I wonder if it would make more sense to have plugin configuration be a different thing? What plugins use jobset inputs for config? |
Concretely, I can imagine someone being confused about why their jobset inputs aren't available to their jobset. Also, it causes perhaps internal confusion about if the inputs should be fetched, or input values tracked over time... overall I'm not keen on this. I wonder if we could create a different way to provide the needed configuration to plugins, or if the plugins should adapt in a different way. |
@grahamc plugins for gitea/gitlab/bitbucket also require a
I could think of a "plugin configuration", but I'm uncertain about the following aspects:
|
It seems to be a common pattern to configure Hydra plugins on a per-jobset basis with jobset inputs. Since these are not needed anymore for flakes, it's also not possible anymore to use plugins for flake jobsets. This patch changes this and adds a warning to avoid confusion. In the future, we may want to restrict jobset inputs for flakes to string values only.
18ff0c7
to
36e7c9e
Compare
@grahamc rebased onto latest master. |
@grahamc any updates here? :) |
@grahamc given your latest comments in the Hydra matrix channel, do you consider this mergeable now? :) |
Needed for Hydra instances using NixOS/hydra#922
Needed for Hydra instances using NixOS/hydra#922
It seems to be a common pattern to configure Hydra plugins on a
per-jobset basis with jobset inputs. Since these are not needed anymore
for flakes, it's also not possible anymore to use plugins for flake
jobsets.
This patch changes this and adds a warning to avoid confusion. In the
future, we may want to restrict jobset inputs for flakes to string
values only.
cc @grahamc