-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating generation of documentation reference #266
Updating generation of documentation reference #266
Conversation
/cc @AlekseyMartynov |
_renderer.Sanitize(member.Summary) + _renderer.RenderLineBreak() + remarks); | ||
} | ||
tableStringBuilder.Append(_renderer.RenderDescriptionBlock(dict)); | ||
|
||
_markupStringBuilder.Append(tableStringBuilder.ToString()); | ||
} | ||
|
||
private static string GenerateAnchor(string text) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this more simple regex work?
return "#" + Regex.Replace(text.ToLower(), "\\W+", "-").Trim('-');
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. Trim('-')
won't replace a character in the middle of a string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The purpose of Trim
is to remove trailing dashes.
For example: "something (something)" is transformed into "something-something-" without Trim
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, your construction produces the correct result.
Document reference generation was updated to produce AnimationScripts reference.