Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paging panel buttons are out of alignment with material UI core 3.1.0 #1413

Closed
2 tasks
stclairdaniel opened this issue Sep 20, 2018 · 3 comments
Closed
2 tasks
Labels

Comments

@stclairdaniel
Copy link

stclairdaniel commented Sep 20, 2018

  • [ x] I have searched this repository's issues and believe that this is not a duplicate.

I'm using ...

  • [x ] React Grid
  • React Chart
  • Vue Grid

Current Behaviour

See screenshot:
screen shot 2018-09-19 at 7 02 28 pm

Expected Behaviour

Arrow buttons and page buttons should be aligned

Steps to Reproduce (for Bugs)

Use a PagingPanel with "@devexpress/dx-react-grid-material-ui": "1.7.2", (and all other devexpress packages at 1.7.2 as well) and "@material-ui/core": "3.1.0" The problem does not exist in 3.0.1.

Environment

  • devextreme-reactive: none
  • react: 16.3.0
  • vue: none
  • browser: Chrome
  • bootstrap: none
  • react-bootstrap: none
  • material-ui: ^3.0.1

Note - This could very well be my fault - I noticed everything looks fine on your demo page, but I see the package.json uses @material-ui/core": "^3.0.1", which will install 3.1.0. When I use MUI 3.0.1, everything looks great as it always have, but if I change to 3.1.0, I see the issue.

Also, if I remove the height style from .Pagination-arrowButton, the issue disappears. This could obviously be a material issue - please let me know if it seems that way and I can try to open an issue there.

@SergeyAlexeev SergeyAlexeev self-assigned this Sep 20, 2018
@sethduncan
Copy link

I have the same issue. This could possibly be related to mui/material-ui#12865 ?

@TheMoonDawg
Copy link

I believe the issue lies in this changeset in IconButton: https://github.com/mui-org/material-ui/pull/12865/files#diff-fde406414bd717fcea45f653b5632078

They switched from resizing the actual component itself to adjusting its padding whenever changing the size of IconButton.

@lock
Copy link

lock bot commented Jun 15, 2019

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants