feat: added the possibility to disable a cross-domain emulation #2806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aleksey28
changed the title
AndreyBelym
approved these changes
Oct 28, 2022
2 tasks
AndreyBelym
added a commit
to DevExpress/testcafe
that referenced
this pull request
Nov 2, 2022
<!-- Thank you for your contribution. Before making a PR, please read our contributing guidelines at https://github.com/DevExpress/testcafe/blob/master/CONTRIBUTING.md#code-contribution We recommend creating a *draft* PR, so that you can mark it as 'ready for review' when you are done. --> [closes #7022] ## Purpose Add `--disable-cross-domain` option ## Approach 1. Add handling CLI option `--disable-cross-domain` 2. Add switching cross-domain ## References #7022 DevExpress/testcafe-hammerhead#2806 ## Pre-Merge TODO - [ ] Write tests for your proposed changes - [ ] Make sure that existing tests do not fail Co-authored-by: Andrey Belym <belym.a.2105@gmail.com> Co-authored-by: Andrey Belym <andrey.belym@devexpress.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add
--disable-cross-domainoptionApproach
Describe how your changes address the issue or implement the desired functionality in as much detail as possible.
References
DevExpress/testcafe#7350
DevExpress/testcafe#7022
testcafe-hammerhead-28.0.1.zip
Pre-Merge TODO