Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added the possibility to disable a cross-domain emulation #7350

Merged
merged 6 commits into from
Nov 2, 2022
Merged

feat: added the possibility to disable a cross-domain emulation #7350

merged 6 commits into from
Nov 2, 2022

Conversation

Aleksey28
Copy link
Collaborator

@Aleksey28 Aleksey28 commented Oct 27, 2022 •
edited
Loading

[closes #7022]

Purpose

Add --disable-cross-domain option

Approach

  1. Add handling CLI option --disable-cross-domain
  2. Add switching cross-domain

References

#7022
DevExpress/testcafe-hammerhead#2806

Pre-Merge TODO

  • Write tests for your proposed changes
  • Make sure that existing tests do not fail

@Aleksey28 Aleksey28 temporarily deployed to CI October 27, 2022 14:27 Inactive
@Aleksey28 Aleksey28 mentioned this pull request Oct 28, 2022
Merged
2 tasks
@Aleksey28 Aleksey28 temporarily deployed to CI October 28, 2022 11:53 Inactive
@Aleksey28 Aleksey28 self-assigned this Oct 28, 2022
@AndreyBelym AndreyBelym temporarily deployed to CI November 2, 2022 08:52 Inactive
@AndreyBelym AndreyBelym enabled auto-merge (squash) November 2, 2022 09:48
@AndreyBelym AndreyBelym merged commit 3351b62 into DevExpress:master Nov 2, 2022
@ssemrau
Copy link

ssemrau commented Nov 3, 2022

Will this feature be also available in runner api and .testcaferc.json?

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Nov 3, 2022
@github-actions
Copy link

github-actions bot commented Nov 3, 2022

Release v2.1.0-rc.1 addresses this.

@Aleksey28
Copy link
Collaborator Author

Hi @semrau,

It is available only in CLI, createTestCafe, and the config file. To set an option in the config file or createTestCafe, you need to use the disable Cross Domain key.

@need-response-app need-response-app bot removed the STATE: Need response An issue that requires a response or attention from the team. label Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreyBelym AndreyBelym AndreyBelym approved these changes

Assignees

@Aleksey28 Aleksey28

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hammerhead.js __get$(document, "location").ancestorOrigins returns <unreadable>
3 participants
@Aleksey28 @ssemrau @AndreyBelym