New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When takeOnFails is triggered, fullPage is ignored: the screenshot is not full-page. #7761
Comments
I managed to reproduce the issue. I confirm that the |
I'm not sure I'm familiar with Thanks for your reply. |
Yes, I meant the |
<!-- Thank you for your contribution. Before making a PR, please read our contributing guidelines at https://github.com/DevExpress/testcafe/blob/master/CONTRIBUTING.md#code-contribution We recommend creating a *draft* PR, so that you can mark it as 'ready for review' when you are done. --> ## Purpose There is an option for testcaferc configuration file called takeOnFails. The issue here was that the screenshot taken by takeOnFails was not responding to option fullPage. The screenshot was always small. ## Approach I found the place where the fullPage option was not passing. Fixed it by passing fullPage option to TakeScreenshotOnFailCommand. ## References #7761 ## Pre-Merge TODO - [x] Write tests for your proposed changes - [x] Make sure that existing tests do not fail
What is your Scenario?
I want to create a screenshot of the entire page on failure.
.takeScreenshot({fullPage: true})
in my test does this, but"takeOnFails": true, "fullPage": true
in my configuration does not.What is the Current behavior?
A non-fullscreen screenshot is taken.
What is the Expected behavior?
A fullscreen screenshot is taken.
What is your public website URL? (or attach your complete example)
https://advancedinstaller.com/blog/page-1.html
What is your TestCafe test code?
Your complete configuration file
Your complete test report
No response
Screenshots
Steps to Reproduce
TestCafe version
2.5.0
Node.js version
v18.15.0
Command-line arguments
'tsc/**.ts'"
Browser name(s) and version(s)
113.0.2 (64-bit)
Platform(s) and version(s)
Windows 10
Other
This has been around for a while and probably exists on chrome browsers, too; I've basically turned this comment into its own issue.
The text was updated successfully, but these errors were encountered: