fix: takeOnFails screenshot with fullPage option fixed #8077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need-response-app
bot
added
the
STATE: Need response
Bayheck
force-pushed
the
takeOnFails-fix
branch
from
9f6d985
to
cc99bef
Compare
PavelMor25
removed
the
STATE: Need response
Aleksey28
requested changes
Nov 14, 2023
There was a problem hiding this comment.
Please. look at my comment and check the test Should take a screenshot on fail and figure out why it didn't work.
aleks-pro
reviewed
Nov 15, 2023
Aleksey28
approved these changes
Nov 16, 2023
aleks-pro
approved these changes
Nov 22, 2023
|
Release v3.5.0-rc.1 addresses this. |
1 similar comment
|
Release v3.5.0-rc.1 addresses this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
There is an option for testcaferc configuration file called takeOnFails. The issue here was that the screenshot taken by takeOnFails was not responding to option fullPage. The screenshot was always small.
Approach
I found the place where the fullPage option was not passing. Fixed it by passing fullPage option to TakeScreenshotOnFailCommand.
References
#7761
Pre-Merge TODO