Improve error handling in IPC utils #4591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Tests for the commit dca4bc9 have failed. See details: |
1 similar comment
|
❌ Tests for the commit dca4bc9 have failed. See details: |
AndreyBelym
changed the base branch from
(testbot-only)compiler-service-flag
to
master
AndreyBelym
force-pushed
the
(testbot-only)ipc-utils-errors
branch
from
dca4bc9
to
9d37d06
Compare
AlexKamaev
approved these changes
Dec 23, 2019
|
❌ Tests for the commit 9d37d06 have failed. See details: |
|
❌ Tests for the commit 9d37d06 have failed. See details: |
|
✅ Tests for the commit 9d37d06 have passed. See details: |
|
ping @Farfurix |
Farfurix
approved these changes
Dec 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed:
Improved
TestCafeErrorListdeserialization (by theTestCafeErrorListerror name) for passingTestCafeErrorList's between the host and compiler service processesAllow prerendered callsites in TestCafe errors. V8 stack frames (which are used to render callsites) don't serialize well, so it's easier to render a whole callsite to a string before transferring it from the compiler service to the host process.