The onActionDone method should take TestRunErrorFormattableAdapter instance instead of Error (closes #4867)
#4847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Tests for the commit 6000808 have failed. See details: |
AlexKamaev
force-pushed
the
formattable_adapters
branch
from
6000808
to
b990318
Compare
|
❌ Tests for the commit b990318 have failed. See details: |
AlexKamaev
changed the title
onActionDoneonActionDone
|
❌ Tests for the commit da66e13 have failed. See details: |
AlexKamaev
force-pushed
the
formattable_adapters
branch
from
da66e13
to
3a23d22
Compare
AlexKamaev
changed the title
onActionDoneonActionDone method should take TestRunErrorFormattableAdapter instance instead of Error (closes #4867)
|
❌ Tests for the commit 3a23d22 have failed. See details: |
|
❌ Tests for the commit 3a23d22 have failed. See details: |
|
✅ Tests for the commit 3a23d22 have passed. See details: |
miherlosev
requested changes
Mar 18, 2020
There was a problem hiding this comment.
If it's possible, I propose to reorganize this code using the following idea:
- error adapters for action errors should be created into the 'executeAction' function
- error adapters for testRun errors (MissingAwaitError, UncaughtError) should be created into the '_executeTestFn'
|
❌ Tests for the commit f6e49d1 have failed. See details: |
|
I closed this version in favor of #4895 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The array of adapters is created when the
executeTestFnfunction catches the error. When it happens we make the screenshot (if screenshot-on-fails is enabled), create adapters and store them into thetestRun.errsproperty. After that we passtestRun.errsto thereportTestDonemethod.Now we also need to pass the TestRunErrorFormattableAdapter to the
onActionDone. So we need to create adapters on theexecuteActionmethod. In addition, we need to make screenshot on theexecuteActionmethod. So we need to catch the error onexecuteAction, create adapter and screenshot and rethrow the error to stop test execution. However, if we rethrow the error we will catch it again onexecuteTestFn.We know that some errors does not occur on the
executeActionstep, but occurs onexecuteTestFn, i.e. error in custom user's code. Thus we somehow need to detect if the error already was processed, and if it was not, we need to process it. I think it's a very bad idea to create adapters and screenshots in two places.Moreover, we have one more layer of catching the errors -
wrapTestFunction. Inside thewrapTestFuncionwe catch execution errors and missing awaits, then create theTestCafeErrorListobject and rethrow it.Thus, inside the catch block of
executeTestFnwe catch theTestCafeErrorListobject.I think that it's better to leave creating adapters and making screenshots on fails as is, in one place: in the
executeTestFncatch block. So in this block I emit newexecution-errorevent which can be handled inside theexecuteActionmethod.