The onActionDone method should take TestRunErrorFormattableAdapter instance instead of Error (closes #4867)
#4895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Tests for the commit de92f1a have failed. See details: |
|
@testcafe-build-bot retest |
|
❌ Tests for the commit de92f1a have failed. See details: |
|
❌ Tests for the commit de92f1a have failed. See details: |
|
❌ Tests for the commit 3e8fd62 have failed. See details: |
|
✅ Tests for the commit 8f58c26 have passed. See details: |
|
❌ Tests for the commit ea423d1 have failed. See details: |
|
✅ Tests for the commit ea423d1 have passed. See details: |
AlexKamaev
changed the title
onActionDone method should take TestRunErrorFormattableAdapter instance instead of Error (closes #4867)
miherlosev
approved these changes
Mar 23, 2020
AndreyBelym
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the third attempt to write clean code for adapters.
In this version logic in more linear than in the first one.
The important moment is that we create a separate adapter for the
action-donemethods. ThustestRunInfo.errs[0]fromtest-run-done!==errfrom 'action-done'.I think it does not really matter, since adapter is only service wrapper above the real error.
In addition, the
errorsarray param onaction-donebecame justerrparam, because action should have only one error.