Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: enabled the "danging-comma" lint rule #6364

Merged
merged 2 commits into from
Jul 12, 2021
Merged

style: enabled the "danging-comma" lint rule #6364

merged 2 commits into from
Jul 12, 2021

Conversation

Aleksey28
Copy link
Collaborator

[closes #6355]

Purpose

Enable the "danging-comma" lint rule

Approach

  1. Enable the lint rule "comma-dangle": ["error", "always-multiline"]
  2. Add commas-dangle in multilines

References

#6355

Pre-Merge TODO

  • Write tests for your proposed changes
  • Make sure that existing tests do not fail

@Aleksey28 Aleksey28 temporarily deployed to CI July 8, 2021 08:33 Inactive
@Aleksey28 Aleksey28 marked this pull request as draft July 8, 2021 08:33
@Aleksey28 Aleksey28 requested review from AndreyBelym and miherlosev and removed request for miherlosev July 8, 2021 09:38
@miherlosev
Copy link
Collaborator

Rebase please

@Aleksey28 Aleksey28 requested review from AlexKamaev and removed request for AndreyBelym July 12, 2021 11:47
@Aleksey28 Aleksey28 temporarily deployed to CI July 12, 2021 11:50 Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI July 12, 2021 11:58 Inactive
@Aleksey28 Aleksey28 marked this pull request as ready for review July 12, 2021 12:28
@miherlosev miherlosev merged commit 016e481 into DevExpress:master Jul 12, 2021
@Aleksey28 Aleksey28 deleted the gh6355 branch December 2, 2021 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miherlosev miherlosev miherlosev approved these changes

@AlexKamaev AlexKamaev Awaiting requested review from AlexKamaev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable the "danging-comma" lint rule
2 participants
@Aleksey28 @miherlosev